Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mark attributes consumed by check_mod_attrs as normal" #69513

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 27, 2020

This reverts commit d78b22f.

Those changes were incompatible with incremental compilation since the
effect check_mod_attrs has with respect to marking the attributes as
used is neither persisted nor recomputed.

This reverts commit d78b22f.

Those changes were incompatible with incremental compilation since the
effect `check_mod_attrs` has with respect to marking the attributes as
used is neither persisted nor recomputed.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2020
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 27, 2020

Reproducer using another attribute:

$ cat src/main.rs
#![feature(marker_trait_attr)]

#[marker]
trait A {}

fn main() {}
$ cargo check
    Checking unused v0.1.0 (/../unused)
    Finished dev [unoptimized + debuginfo] target(s) in 0.43s
$ touch src/main.rs
$ cargo check
    Checking unused v0.1.0 (/../unused)
warning: unused attribute
 --> src/main.rs:3:1
  |
3 | #[marker]
  | ^^^^^^^^^
  |
  = note: `#[warn(unused_attributes)]` on by default

    Finished dev [unoptimized + debuginfo] target(s) in 0.25s

Looks like the general incompatibility of unused attributes lint
with incremental compilation is a known issue: #58633, #65023.

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 27, 2020

📌 Commit 34f8394 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2020
@nnethercote
Copy link
Contributor

nnethercote commented Feb 27, 2020

@bors p=1

Because it fixes a perf regression.

@bors
Copy link
Contributor

bors commented Feb 27, 2020

⌛ Testing commit 34f8394 with merge fbc46b7...

@bors
Copy link
Contributor

bors commented Feb 28, 2020

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing fbc46b7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2020
@bors bors merged commit fbc46b7 into rust-lang:master Feb 28, 2020
@tmiasko tmiasko deleted the revert-checked-unused branch February 28, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants